Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rprimarycensoreddist: Censor and truncate or truncate and censor #23

Closed
seabbs opened this issue Sep 3, 2024 · 2 comments · Fixed by #26
Closed

rprimarycensoreddist: Censor and truncate or truncate and censor #23

seabbs opened this issue Sep 3, 2024 · 2 comments · Fixed by #26
Assignees
Labels
enhancement New feature or request

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 3, 2024

As the title I think the order that these take place is matters in some settings (as observation should I think be based on the continuous distribution and not the secondary event censored one).

That is the reverse of what we currently have (and what we have been doing historically). I think in most of the settings we have been considered (where D is a multiple of the secondary event window) the ordering doesn't matter and so perhaps that explains why this hasn't come up.

@seabbs
Copy link
Contributor Author

seabbs commented Sep 3, 2024

@athowes any thoughts on this?

@seabbs seabbs closed this as completed in #26 Sep 4, 2024
@athowes
Copy link
Contributor

athowes commented Sep 4, 2024

(I vaguely get that there might be a difference depending on whether you censor first or truncate first but don't have any good thoughts about it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants