Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use project.slug instead or project.id on routes #229

Merged
merged 6 commits into from
Mar 15, 2023
Merged

feat: use project.slug instead or project.id on routes #229

merged 6 commits into from
Mar 15, 2023

Conversation

ttebify
Copy link
Collaborator

@ttebify ttebify commented Mar 14, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Replace all the project specific routes with slug instead of routes. Attempt Fix #195

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  1. Test the project routes sequentially to ensure successful navigation through each of them.
  2. Test on the checkSlugOrNameAvailability function with different values to ensure that it returns the expected result.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@ttebify ttebify changed the title feature: use project.slug instead or project.id on routes feat: use project.slug instead or project.id on routes Mar 14, 2023
@ttebify ttebify marked this pull request as ready for review March 14, 2023 12:55
Copy link
Member

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this PR @ttebify 🎉 👏🏼

@dahal dahal merged commit e6a14bb into envless:main Mar 15, 2023
@ttebify
Copy link
Collaborator Author

ttebify commented Mar 15, 2023

I'm happy to contribute 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: use project.slug instead or project.id on routes
2 participants