-
-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Iterable
instead Iterator
on iterate_in_threadpool
#2362
Merged
Kludex
merged 7 commits into
encode:master
from
jamesbraza:fixing-async-content-stream-typing
Dec 20, 2023
Merged
Use Iterable
instead Iterator
on iterate_in_threadpool
#2362
Kludex
merged 7 commits into
encode:master
from
jamesbraza:fixing-async-content-stream-typing
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
changed the title
Fixed
Fixed Dec 7, 2023
AsyncContentStream
typing to be AsyncIterator
AsyncContentStream
typing to be AsyncIterable
Cc @tomchristie if you got time to take a look at this one, it's another bug I encountered recently |
Kludex
requested changes
Dec 13, 2023
@jamesbraza you probably want to check in with other encode maintainers for this project. (I'm focused on |
Kludex
requested changes
Dec 13, 2023
Kludex
reviewed
Dec 16, 2023
Kludex
approved these changes
Dec 18, 2023
Kludex
changed the title
Fixed
Use Dec 20, 2023
AsyncContentStream
typing to be AsyncIterable
Iterable
instead Iterator
on iterate_in_threadpool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Having
AsyncContentStream
match typing ofSyncContentStream
, they should both beIterator
orIterable
, not separate.Giveniterate_in_threadpool
is typed withIterator
, and returns anAsyncIterator
, I think thenAsyncContentStream
should be anIterator
as wellFrom
mypy
inferred types intest_streaming_response_custom_iterable
, it seemsAsyncIterable
is required. So, this PR standardizes onIterable
/AsyncIterable
Checklist