Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs correction in the steps to manually install this. #13

Open
rkrjain opened this issue Aug 8, 2014 · 2 comments
Open

Needs correction in the steps to manually install this. #13

rkrjain opened this issue Aug 8, 2014 · 2 comments

Comments

@rkrjain
Copy link

rkrjain commented Aug 8, 2014

I had to place the contents of the extracted folder into the pvv8 folder in order to make it work.

Creating a folder with the downloaded folder name didn't work

PyV8 folder -> should contain the PyV8.py.

I am using ST3

@clauzf
Copy link

clauzf commented Dec 4, 2014

Hi, @rgjain I did what you said, but still PyV8 is not loaded correctly. I tried moving only PyV8.py and both that and _PyV8.py. Can you share more details about how to get it working?

reloading plugin PyV8.PyV8
Traceback (most recent call last):
  File "C:\Sublime Text 3 x64\sublime_plugin.py", line 73, in reload_plugin
    m = importlib.import_module(modulename)
  File "./importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 584, in _check_name_wrapper
  File "<frozen importlib._bootstrap>", line 1022, in load_module
  File "<frozen importlib._bootstrap>", line 1003, in load_module
  File "<frozen importlib._bootstrap>", line 560, in module_for_loader_wrapper
  File "<frozen importlib._bootstrap>", line 868, in _load_module
  File "<frozen importlib._bootstrap>", line 313, in _call_with_frames_removed
  File "C:\Sublime Text 3 x64\Data\Packages\PyV8\PyV8.py", line 32, in <module>
    import _PyV8
ImportError: No module named '_PyV8'

@gravidThoughts
Copy link

Thanks @rgjain.

The instructions located at https://github.com/emmetio/pyv8-binaries#readme are incorrect for ST3 windows x64. The compiled binaries must go directly into the PyV8 folder. If you place the binaries in a subfolder of PyV8 named after the zip file, it will continue to fail.

Please update the instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants