You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using eframe (especially compiling for wasm32-unknown-unknown) version 1.17, the code will fail to compile when using cargo resolver v1. For most recent crates (edition 2021) this should not be a problem, but when using multiple edition 2021 crates in a workspace with a virtual manifest, the resolver v1 will be used. This is marked as working as intended see here, but can be confusing when expecting to be using the resolver v2 in your workspace.
It would be useful to inform consumers of eframe (especially wasm32) that resolver v2 is required.
Resolver v1 failing is caused by these dependencies on eframe:
Intuitively this looks correct, and with resolver v2 is is correct. But in resolver v1, the features for target.'cfg(not(target_arch = "wasm32"))'.dependencies and target.'cfg(target_arch = "wasm32")'.dependencies are merged, meaning that the egui_glow/winit feature is enabled on wasm32, but the egui-winit dependency is not specified. This leads to a weird error in eframe of the external crate egui-winit not being found when compiling to wasm32.
The text was updated successfully, but these errors were encountered:
When using eframe (especially compiling for
wasm32-unknown-unknown
) version 1.17, the code will fail to compile when using cargo resolver v1. For most recent crates (edition 2021) this should not be a problem, but when using multiple edition 2021 crates in a workspace with a virtual manifest, the resolver v1 will be used. This is marked as working as intended see here, but can be confusing when expecting to be using the resolver v2 in your workspace.It would be useful to inform consumers of eframe (especially wasm32) that resolver v2 is required.
Resolver v1 failing is caused by these dependencies on eframe:
https://github.com/emilk/egui/blob/master/eframe/Cargo.toml#L55-L63
Intuitively this looks correct, and with resolver v2 is is correct. But in resolver v1, the features for
target.'cfg(not(target_arch = "wasm32"))'.dependencies
andtarget.'cfg(target_arch = "wasm32")'.dependencies
are merged, meaning that theegui_glow/winit
feature is enabled on wasm32, but the egui-winit dependency is not specified. This leads to a weird error in eframe of the external crate egui-winit not being found when compiling to wasm32.The text was updated successfully, but these errors were encountered: