Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created an es5-getter-ember-codemod that might be a good addition #255

Closed
rondale-sc opened this issue Feb 7, 2018 · 3 comments · Fixed by #289
Closed

Created an es5-getter-ember-codemod that might be a good addition #255

rondale-sc opened this issue Feb 7, 2018 · 3 comments · Fixed by #289

Comments

@rondale-sc
Copy link
Contributor

This codemod is intended to automatically convert your usage of get, and getProperties to use traditional object dot notation as proposed by emberjs/rfcs#281.

https://github.com/rondale-sc/es5-getter-ember-codemod
@kellyselden
Copy link
Member

Definitely lets add this. We have minimum version support, so you can add it now with minimum version 3.2, which I believe is the correct version minimum.

@rwjblue
Copy link
Member

rwjblue commented Apr 5, 2018

3.1 is where the feature was introduced...

@rondale-sc
Copy link
Contributor Author

@kellyselden I'll put this on my TODO list for tomorrow.

@rondale-sc rondale-sc mentioned this issue Apr 6, 2018
Merged
@adriaandotcom adriaandotcom mentioned this issue Jun 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add es5-getter-ember-codemod to list of codemods to run rondale-sc/ember-cli-update
3 participants
@rwjblue @rondale-sc @kellyselden