Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large thumbnails undershoot the requested size #5302

Open
matrixbot opened this issue Dec 17, 2023 · 0 comments
Open

Large thumbnails undershoot the requested size #5302

matrixbot opened this issue Dec 17, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 17, 2023

This issue has been migrated from #5302.


If you request a larger thumbnail size than the largest precalculated thumbnail, you'll get the largest precalculated thumbnail, which could significantly undershoot the requested size.

This will end up looking horrible and blurry as the client then scales up the thumbnail to the size it asked for.

In Riot/Web (as of matrix-org/matrix-react-sdk#2439) we explicitly ask for the original image if the thumbnail exceeds 800x600, but we might do better to handle this more intelligently. Perhaps the solution is just to pregenerate even bigger thumbnails? Or default to serving the original image?

@matrixbot matrixbot changed the title Dummy issue Large thumbnails undershoot the requested size Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant