Support for MSC3886 no longer needs to be maintained

[hughns]

Further to #17151 support for MSC3886 no longer needs to be maintained. As such it can be deprecated and/or removed at the team's discretion.

[rahulporuri]

@hughns I'm guessing that means deprecating/removing the code added in commits like hughns@4eaf3eb

@anoadragon453 will the code go through a deprecation cycle or can it be removed outright?

I recently started using matrix/element and I'm happy to contribute.

[anoadragon453]

@rahulporuri thanks for the offer to contribute! As it's an experimental feature, it can simply be removed without a deprecation timeline. Be sure to remove all of:

• The experimental msc3886_endpoint config option.
• Any code that relies on it.
• Any tests related to it.
• Any documentation related to it.

and use a .removal changelog entry when describing the change for the changelog.

Feel free to ask here if you have further questions, or in #synapse-dev:matrix.org 🙂

[rahulporuri]

@anoadragon453 i opened #17638. i think it is complete. please take a look when you have the time

[rahulporuri]

Also, @anoadragon453 is a "deprecated"/"removal" label useful in the repository? I'm not if there are other issues that discuss deprecating/removing code.

[anoadragon453]

@rahulporuri thanks! It'll sit in the review queue for a bit until someone gets to it.

is a "deprecated"/"removal" label useful in the repository? I'm not if there are other issues that discuss deprecating/removing code.

It could be if you're specifically looking to go around deleting code. Does searching for "remove", "deprecate" in issue titles not bring up results though?