-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synapse still responds to /_matrix/key/v2/server/{keyId} #17323
Comments
It was intentional, there was no way to be compliant with both the new spec and old spec. Would need to dig back through blame to find the conversation about it. |
Ok, I see. There's probably no concrete plan to ditch support for the old spec then, or is there? |
For reference: the conversation about this issue happened here: matrix-org/synapse#15089 (comment) As far as I'm aware, there is no concrete plan to stop supporting the old spec at this time. The team can take a look at this & consider what the plan should be. |
Thanks a lot both! I think we can close this then. |
Update: The team took a look and the plan is to continue supporting the endpoint until it is fully removed from the spec. |
The
/{keyId}
parameter has been removed in Matrix v1.6. This version of the specification also included another change that mandates a 404 response for requests to unsupported endpoints:However, Synapse appears to still respond to requests with
/{keyId}
as if the path component was missing. See e.g. https://matrix-federation.matrix.org/_matrix/key/v2/server/foo which returns the same 200 response as https://matrix-federation.matrix.org/_matrix/key/v2/server rather than a 404.I assume this might actually be intentional because until late 2022 Synapse itself specified the parameter on outgoing requests. However, given that this isn't part of the spec anymore I'm curious what the migration path is here, if any?
For context: I'm poking at this with my gematik hat on as we're trying to expose and prevent compatibility problems within the gematik ecosystem. The latter is currently on Matrix v1.3 but once we update our specification we'll also have v1.10 implementations in the same federation.
The text was updated successfully, but these errors were encountered: