Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Use id_access_token in CS API when required #3295

Closed
manuroe opened this issue Sep 9, 2019 · 3 comments
Closed

Use id_access_token in CS API when required #3295

manuroe opened this issue Sep 9, 2019 · 3 comments

Comments

@manuroe
Copy link
Member

manuroe commented Sep 9, 2019

Make sure we pass the token on CS APIs that need it, ie:

  • inviteByThreePid: POST /rooms/$roomId/invite
  • all /requestToken APIs:
    • /register/email/requestToken
    • /register/msisdn/requestToken
    • /account/3pid/email/requestToken
    • /account/3pid/msisdn/requestToken
    • /account/password/email/requestToken
    • /account/password/msisdn/requestToken
@manuroe
Copy link
Member Author

manuroe commented Sep 16, 2019

With https://github.com/matrix-org/matrix-doc/blob/anoa/msc_separate_hs_api/proposals/2290-separate-threepid-bind-hs.md, it seems we will not need this token for:
- /account/3pid/email/requestToken
- /account/3pid/msisdn/requestToken
- /account/password/email/requestToken
- /account/password/msisdn/requestToken

TODO: douche check this and check requirements for others. Then, update the issue.

@BillCarsonFr BillCarsonFr self-assigned this Sep 16, 2019
@anoadragon453
Copy link
Member

The required endpoints should just be:

  • POST /rooms/$roomId/invite
  • POST /createRoom

The /requestToken endpoints (at least password and registration) shouldn't need it. I'll try to figure out what's up.

@BillCarsonFr
Copy link
Member

See #3322

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants