Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Replace MatrixClient.isCryptoEnabled by MatrixClient.getCrypto #140

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Replace MatrixClient.isCryptoEnabled by MatrixClient.getCrypto #140

merged 4 commits into from
Oct 15, 2024

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Oct 10, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task element-hq/element-web#26922
Replace the deprecated MatrixClient.isCryptoEnabled by MatrixClient.getCrypto

@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 10, 2024
@florianduros florianduros mentioned this pull request Oct 10, 2024
Open
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/remove-isCryptoEnabled branch from bbfb413 to 0a8709f Compare October 10, 2024 13:38
@florianduros florianduros marked this pull request as ready for review October 10, 2024 14:04
@florianduros florianduros requested review from a team as code owners October 10, 2024 14:04
dbkr
dbkr reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mind having an explicitly named function, but if that's what the API is now then I guess that's what we do.

src/components/structures/MatrixChat.tsx Outdated Show resolved Hide resolved
@florianduros florianduros requested a review from dbkr October 14, 2024 07:55
@florianduros florianduros added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@florianduros florianduros added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@florianduros florianduros added this pull request to the merge queue Oct 15, 2024
Merged via the queue into develop with commit 950ab19 Oct 15, 2024
27 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/remove-isCryptoEnabled branch October 15, 2024 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianduros @dbkr @richvdh