Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions: Push notifications display user mentions differently #1825

Closed
Tracked by #2065
Velin92 opened this issue Sep 28, 2023 · 2 comments · Fixed by #2050
Closed
Tracked by #2065

Mentions: Push notifications display user mentions differently #1825

Velin92 opened this issue Sep 28, 2023 · 2 comments · Fixed by #2050
Assignees
@Velin92
Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design

Comments

@Velin92
Copy link
Member

Velin92 commented Sep 28, 2023 •
edited
Loading

As of right now they are displayed as links, but they probably should be converted into text

Mentions should be displayed with @username in the notification (however since the username is usually not available in the notification context, is also okay to prefix with @ the hyperlink text just to make it clear that is a mention from the notification)

Also if you have been mentioned in the notification we should prefix the notification body with:
"Username mentioned you"
or
"You have been mentioned" if the username of the sender is not available
@Velin92 Velin92 added X-Needs-Design T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Notifications labels Sep 28, 2023
@Velin92 Velin92 self-assigned this Sep 28, 2023
@Velin92 Velin92 mentioned this issue Sep 28, 2023
Closed
@Velin92
Copy link
Member Author

Velin92 commented Sep 28, 2023

Kamino cloned this issue to vector-im/element-x-android

@Velin92 Velin92 mentioned this issue Sep 28, 2023
Open
6 tasks
@Velin92 Velin92 mentioned this issue Nov 9, 2023
Merged
@Velin92 Velin92 mentioned this issue Nov 13, 2023
Closed
@Velin92
Copy link
Member Author

Velin92 commented Nov 13, 2023

Kamino cloned this issue to vector-im/element-x-ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velin92 Velin92

Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom copy for notifications that contain mentions element-hq/element-x-ios
1 participant
@Velin92