Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Optionally) Warn when inviting users who might not exist. #8050

Closed
lampholder opened this issue Jan 8, 2019 · 1 comment
Closed

(Optionally) Warn when inviting users who might not exist. #8050

lampholder opened this issue Jan 8, 2019 · 1 comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect T-Enhancement

Comments

@lampholder
Copy link
Member

We made a change to the invite UX to stop people mistakenly inviting 'nonexistant' mxids.

The change relied on checking a user's /profile to establish whether they exist or not, but it's become clear that this isn't always appropriate - particulary in the case of bridged users.

A spec change is being discussed as to the merits of checking /profile and how we might enhance this API (or add a new one) to handle checking whether a user exists. However, we've decided that for now we can power through client side if we:

  • expose a warning when you try and invite a mxid we can't confirm exists (but let you continue with the invite if you wish)
  • make this warning optional, to be configured on either a per user or per riot deploy basis
@lampholder lampholder added T-Defect feature P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 8, 2019
@lampholder
Copy link
Member Author

Closing in favour of #7922 (where I should have written the above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect T-Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants