Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking room meta notifications as read does not work #5756

Closed
vsund opened this issue Dec 1, 2017 · 4 comments
Closed

Marking room meta notifications as read does not work #5756

vsund opened this issue Dec 1, 2017 · 4 comments
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@vsund
Copy link
Contributor

vsund commented Dec 1, 2017

Description

I'm in a bridged IRC channel with low traffic but much user fluctuation (many joins/leaves without real messages in between). When I try to mark these "meta messages" (joins/leaves) as read, the notification at the top ("unread messages, mark as read?") appears again immediately.

Steps to reproduce

  • Join a room with many meta messages (typically a bridged IRC channel with many joins/leaves)
  • Wait some time until the screen gets filled up with these messages (they collapse if there are enough)
  • Click "mark as read"

The click on "mark as read" should now mark all these meta messages as read but it appears again immediately. I'm not sure whether this is related to the collapsed view of these messages, notifications for these meta messages or to something entirely different.

To get it marked as read, I need to expand them all and then mark them as read.

I'm also not sure whether it's necessary to see these joins/leaves as important to notify the user. Furthermore the room is displayed bold (as if there were unread messages) again and again.

Also not sure whether #2629 is related.

Version information

I'm using the desktop client in version 0.13.2 on Arch Linux.

@turt2live
Copy link
Member

"mark as read" was a button from several versions ago. Are you sure you're on 0.13.2?

@vsund
Copy link
Contributor Author

vsund commented Dec 1, 2017

@turt2live Yup, sorry for the confusion, wrote this up from mind. It's a "Jump to first unread message." label with an X on the right side (which should have the same effect I guess).

@turt2live
Copy link
Member

Ah, alright then. It sounds like a side effect of #2629

@lampholder lampholder added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P2 ui/ux labels Dec 5, 2017
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@t3chguy
Copy link
Member

t3chguy commented Nov 27, 2024

Closing as believed fixed, no reproduction in years

@t3chguy t3chguy closed this as completed Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants