Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ouput devices setting #4203

Closed
kuon opened this issue Jun 5, 2017 · 8 comments
Closed

Add ouput devices setting #4203

kuon opened this issue Jun 5, 2017 · 8 comments

Comments

@kuon
Copy link

kuon commented Jun 5, 2017

Current version allow only to set the microphone device. I think it would make sense to add a setting for the output device and optionally the ringing device.

Version

Homeserver is https://matrix.org
Identity Server is https://vector.im
matrix-react-sdk version: 0.9.1
riot-web version: 0.10.1
olm version: 2.2.1

@t3chguy
Copy link
Member

t3chguy commented Jun 5, 2017

Ringing device we won't have control over, that'll just be whatever audio device the browser is outputting to, voip we should be able to direct to a specific output

@kuon
Copy link
Author

kuon commented Jun 5, 2017

The voice output device is already a big step.

@benrob0329
Copy link

We really need this, VoIP is unusable for some people without it.

@krodelabestiole
Copy link

Apparently it has been implemented by the W3C for WebRTC :
https://w3c.github.io/mediacapture-output/
https://bugs.chromium.org/p/webrtc/issues/detail?id=2243

I don't know how well implemented this functionality is on browsers and electron though...

@t3chguy
Copy link
Member

t3chguy commented Apr 10, 2018

It's definitely possible just missing someone to work on implementing it in react-sdk and js-sdk

@krodelabestiole
Copy link

From my understanding we now have one audio output we can choose. Thanks !

Would it be possible to have two : one for the ringing and one for the communication.
(for people who use headphones e.g.)

@t3chguy could you please reopen (since devices is plural in Add ouput devices) or should I open a new issue ?

@t3chguy
Copy link
Member

t3chguy commented Sep 4, 2018

I don't know how feasibly that can be done given that it's just a Web browser under the hood which doesn't have such controls

@krodelabestiole
Copy link

it depends on electron I guess (or any browser for the web app)

but if you can't route 2 different signals on two different outputs at the same time, due to the technology riot is based on, first we could push a feature request to these techno, and then there is still the workaround to switch on two different outputs depending on if a conversation is currently occurring or no... I guess... no ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants