Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sign windows electron builds #2815

Closed
ara4n opened this issue Dec 24, 2016 · 4 comments
Closed

sign windows electron builds #2815

ara4n opened this issue Dec 24, 2016 · 4 comments
Labels
A-Electron P1 Security Z-Platform-Specific

Comments

@ara4n
Copy link
Member

ara4n commented Dec 24, 2016 •
edited
Loading

we need to buy a windows code signing certificate.
@ara4n
Copy link
Member Author

ara4n commented Feb 21, 2017

/me sighs - riot.exe for 0.9.7 is showing up as a false AV positive in some places: https://www.virustotal.com/en/file/b15161ab7428e9cd952bc0641818fe7c09cc2134d95ce2fc6672acb28e346dca/analysis/1487718052/

According to Squirrel/Squirrel.Windows#218 it sounds like the right solution is to sign the code, which i guess we should do anyway as more windows installs start running around the place.

@t3chguy
Copy link
Member

t3chguy commented Jun 12, 2018

This is now done
image

@t3chguy t3chguy closed this as completed Jun 12, 2018
@turt2live
Copy link
Member

Is the actual binary also signed and not just the setup? Historically I've never had a problem with the installer, but opening riot causes the AV to freak out and quarantine it.

@t3chguy
Copy link
Member

t3chguy commented Jun 12, 2018

@turt2live thats #5948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Electron P1 Security Z-Platform-Specific
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @ara4n @t3chguy