Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email verification text is wrong when doing a password reset #2761

Closed
ara4n opened this issue Dec 18, 2016 · 2 comments
Closed

Email verification text is wrong when doing a password reset #2761

ara4n opened this issue Dec 18, 2016 · 2 comments

Comments

@ara4n
Copy link
Member

ara4n commented Dec 18, 2016

The email says:

"We have received a request from 83.166.64.36 to register this email address on riot.im."

However, this is wrong, because:

  • The IP address is wrong, it's leaking an internal one rather than using my external one
  • I'm not trying to register an email address, i'm trying to reset a password!
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Apr 13, 2017

The first issue was fixed by matrix-org/sydent#41

The password reset email now reads "You have asked us to register this email address with riot.im". It seems we use the same email for possibly any kind of email verification.

Easy, simple option: "You have asked us to verify that this email belongs to an account on riot.im" (this would make sense for password reset / registration / adding a new email address.)
Hard option: Create a new template on sydent specifically for password reset.

@lampholder, any thoughts?

@novocaine
Copy link
Contributor

Closing as fixed as noted above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants