Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkifier not working with more than one dot in domain name #2756

Closed
VShell opened this issue Dec 18, 2016 · 3 comments
Closed

Linkifier not working with more than one dot in domain name #2756

VShell opened this issue Dec 18, 2016 · 3 comments
Labels
A-Timeline P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@VShell
Copy link

VShell commented Dec 18, 2016

When linking to rooms like #erlang:57north.org.uk, only #erlang:57north.org gets turned into a link. Same with #letstesthis:halfshot.co.uk ending at the .co. However, #thisisatest:foo.example.com works. I assume that the issue is that .org and .co are valid TLDs, so the linkifier is not greedy enough?
@Half-Shot
Copy link
Member

I'm wondering why the linkifier is even verifying TLDs at all. I'd either go all the way and verify the HS/room/user_id or don't verify and let the user click through.

@ara4n ara4n added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P1 A-Timeline labels Dec 20, 2016
@uhoreg uhoreg mentioned this issue Mar 26, 2017
Closed
@turt2live turt2live mentioned this issue May 11, 2018
Closed
@t3chguy
Copy link
Member

t3chguy commented Jun 23, 2018

image
its not related to the number of dots in the domain

@t3chguy
Copy link
Member

t3chguy commented Jun 23, 2018

it gets weirder
image

@t3chguy t3chguy mentioned this issue Jun 23, 2018
Merged
@t3chguy t3chguy closed this as completed Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@VShell @ara4n @Half-Shot @t3chguy