Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Leave space" should always be the bottom action in the space menu #23627

Closed
kittykat opened this issue Oct 27, 2022 · 8 comments
Closed

"Leave space" should always be the bottom action in the space menu #23627

kittykat opened this issue Oct 27, 2022 · 8 comments
Labels
A-Spaces Spaces, groups, communities good first issue Good for newcomers Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement

Comments

@kittykat
Copy link
Contributor

Your use case

What would you like to do?

Have red/destructive actions at the bottom of the menu

Why would you like to do it?

Because they should be the least used

How would you like to achieve it?

By swapping "See room timeline" and "Leave space" in the menu

Have you considered any alternatives?

No response

Additional context

Screenshot from 2022-10-27 12-11-48

@kittykat kittykat added S-Tolerable Low/no impact on users A-Spaces Spaces, groups, communities Help Wanted Extra attention is needed T-Enhancement O-Uncommon Most users are unlikely to come across this or unexpected workflow good first issue Good for newcomers labels Oct 27, 2022
@KartikBudania
Copy link

@kittykat @justjanne Please assign this issue to me.

@justjanne
Copy link
Contributor

@kittykat @justjanne Please assign this issue to me.

We generally do not assign issues anymore. Feel free to write a PR for it even without being assigned to it.

@KartikBudania
Copy link

KartikBudania commented Oct 28, 2022

We generally do not assign issues anymore. Feel free to write a PR for it even without being assigned to it.

@justjanne please help me identify the file/code responsible for the issue so that I can start writing the PR.

@KartikBudania
Copy link

@kittykat would you please help me identify the file/code responsible for the issue?

@kittykat
Copy link
Contributor Author

kittykat commented Oct 29, 2022

@kittykat would you please help me identify the file/code responsible for the issue?

Please be patient. It's the weekend so our developers may take until Monday to follow up :)

I'm not familiar with the code, but you can try searching the code for the string and work your way back from that until you find that menu. Your IDE should provide you with appropriate tools to do that or you can use git grep

@KartikBudania
Copy link

@kittykat thanks for your guidance :)

@t3chguy
Copy link
Member

t3chguy commented Oct 31, 2022

@KartikBudania search in https://github.com/matrix-org/matrix-react-sdk

@florianduros
Copy link
Member

Merged in develop in the react-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities good first issue Good for newcomers Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants