Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid implementation of MSC3890 #23384

Closed
t3chguy opened this issue Sep 30, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#9336
Closed

Invalid implementation of MSC3890 #23384

t3chguy opened this issue Sep 30, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#9336
Assignees
Labels

Comments

@t3chguy
Copy link
Member

t3chguy commented Sep 30, 2022

While no local_notification_settings event exists for the current device, or a local_notification_settings event exists where is_silenced is falsy, events should be processed as normal and trigger system notifications and sounds where necessary.

Says to treat no event or no is_silenced as if it were false, we default to true: https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/utils/notifications.ts#L54

The wrong unstable prefix is used also org.matrix.msc3890.local_notification_settings vs https://github.com/matrix-org/matrix-spec-proposals/blob/60695654956019c51f88f0f88ca02280ef00bc13/proposals/3890-remote-local-notification-toggle.md#unstable-prefix

@germain-gg germain-gg self-assigned this Sep 30, 2022
@germain-gg
Copy link
Contributor

germain-gg commented Sep 30, 2022

The rendered link in the MSC does not point to the latest commit. The implementation is correct.

Will fix the default behaviour. I parsed that wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants