Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the new search dialog accessible #22361

Closed
Tracked by #21121
kittykat opened this issue May 26, 2022 · 4 comments
Closed
Tracked by #21121

Make the new search dialog accessible #22361

kittykat opened this issue May 26, 2022 · 4 comments
Assignees
@justjanne
Labels
A-New-Search-Experience The new search dialog available in Labs O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Tasks for the team like planning Z-Labs

Comments

@kittykat
Copy link
Contributor

kittykat commented May 26, 2022 •
edited
Loading

The new search dialog needs to be accessible, especially for screen reader users.

Resources:
@kittykat kittykat mentioned this issue May 26, 2022
Closed
21 tasks
@kittykat kittykat added T-Task Tasks for the team like planning S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-New-Search-Experience The new search dialog available in Labs labels May 26, 2022
@justjanne
Copy link
Contributor

The user ticket gives us the following tasks:

@niquewoodhouse
Copy link

  • The room list / space list can not be reached via a shortcut directly

Maybe I am misunderstanding, but I don't understand why this is relevant specifically to the new search? The room list and space list are separate features which currently don't have shortcuts, do they? But A user can use a keyboard shortcut cmd + f in chrome to find text in the UI for room list - or is that taken up by something else in element?

  • Rooms and Users should have a context menu in search results the same as if they’re shown in a room or member list

As in, give them these icons/the options within them?
image

@t3chguy
Copy link
Member

t3chguy commented Jun 27, 2022 •
edited
Loading

Maybe I am misunderstanding, but I don't understand why this is relevant specifically to the new search? The room list and space list are separate features which currently don't have shortcuts, do they?

Because previously Ctrl/Cmd K would take you to the room filter field atop the room list from where you could tab/down arrow into the room list or shift tab into the space panel.

But A user can use a keyboard shortcut cmd + f in chrome to find text in the UI for room list - or is that taken up by something else in element?

Electron App doesn't have Cmd + F, optionally you can bind it to message search, this is also not a hugely accessible solution as the Space Panel has no text at all.

@justjanne justjanne mentioned this issue Jun 27, 2022
Merged
@justjanne
Copy link
Contributor

We'll move the discussion regarding the context menus and the requested shortcuts for the space/room list into separate issues

@justjanne justjanne closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2022
This was referenced Jun 28, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justjanne justjanne

Labels
A-New-Search-Experience The new search dialog available in Labs O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Tasks for the team like planning Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @niquewoodhouse @t3chguy @justjanne