Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can reply with m.emote contrary to spec, breaking reply fallbacks #21104

Closed
HarHarLinks opened this issue Feb 16, 2022 · 2 comments
Closed

Can reply with m.emote contrary to spec, breaking reply fallbacks #21104

HarHarLinks opened this issue Feb 16, 2022 · 2 comments
Assignees
@t3chguy
Labels
A-Replies reply O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

  1. click reply
  2. write /me repros this issue

Outcome

What did you expect?

This is not allowed
https://github.com/matrix-org/matrix-doc/blob/c420fc49a0905709be2e14ed2b7eafa1b3832331/content/client-server-api/modules/instant_messaging.md#L321

What happened instead?

It "just works" on desktop and clients not relying on reply fallbacks, but breaks the fallback on others (e.g. E android)

Operating system

arch

Application version

Element Nightly version: 2022021601 Olm version: 3.2.8

How did you install the app?

aur

Homeserver

1.52

Will you send logs?

No
@HarHarLinks
Copy link
Contributor Author

related #6986 which wanted to allow it - though it's still broken on android:
image

desktop:
image

@dbkr dbkr added A-Replies reply O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 17, 2022
@t3chguy t3chguy self-assigned this Mar 10, 2022
@t3chguy
Copy link
Member

t3chguy commented Mar 10, 2022

As per MSC3676 this is valid
https://github.com/matrix-org/matrix-spec-proposals/blob/matthew/msc3676/proposals/3676-transitioning-away-from-reply-fallbacks.md

@t3chguy t3chguy closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Replies reply O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbkr @t3chguy @HarHarLinks