Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Tab on spotlight without typing looks weird #20645

Closed
BurnyBoi opened this issue Jan 19, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7624
Closed

Using Tab on spotlight without typing looks weird #20645

BurnyBoi opened this issue Jan 19, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7624
Assignees
Labels
A11y A-New-Search-Experience The new search dialog available in Labs O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@BurnyBoi
Copy link

BurnyBoi commented Jan 19, 2022

Steps to reproduce

  1. Open spotlight search
  2. Use Tab to navigate through the Recently Viewed room list without typing a search term

Outcome

What did you expect?

Tab should highlight each room as it tabs through them

What happened instead?

The selected room is only indicated by having both the room name and the "this room is public" labels display near the selection, overlapping one another.

pic-selected-220119-1236-31

It looks like there is some highlighting effect on "MyTest", but it doesn't move with Tab. Matrix HQ is selected and Enter opens Matrix HQ.

Operating system

Arch Linux

Browser information

Firefox 95

URL for webapp

develop.element.io

Application version

Element version: 840867b-react-ec6bb8806822-js-a50a627300df Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

No

@HarHarLinks
Copy link
Contributor

HarHarLinks commented Jan 19, 2022

related #20339, though this one is more of an accessibility defect rather than navigation improvement

@dbkr dbkr added A-New-Search-Experience The new search dialog available in Labs O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 20, 2022
@t3chguy t3chguy self-assigned this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A-New-Search-Experience The new search dialog available in Labs O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants