Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn before recursively leaving and bricking many rooms when leaving a space #19124

Closed
rda0 opened this issue Sep 22, 2021 · 1 comment
Closed
Labels
A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Design

Comments

@rda0
Copy link
Contributor

rda0 commented Sep 22, 2021

Steps to reproduce

  1. Use a private spaces tree to organize all your rooms
  2. Leave the space
  3. Select Leave all rooms and spaces (randomly or by accident)
  4. Notice that you lost access to all private rooms and abandoned all rooms where you were the only admin

What did you expect?

A very prominent popup dialog warning the user that this action could be dangerous and will result in unrecoverable loss of rooms and access permissions. Example:

Are you really sure you want to:

  • leave XXX public rooms
  • leave XXX private rooms and loose access
  • abandon (brick) XXX private rooms where you are the only admin (probably loosing them forever)

What happened?

No warning.

Notes

This actually happened to one of my co-workers, who knows Matrix very well. The co-worker wanted to leave a private test space and just selected the wrong option when leaving. I think the main action is leaving a space and an option to recursively leave all contained rooms should maybe even be hidden behind an advanced option (like the UI for creating unfederated rooms).

The leave space dialog:
image
only mentions that you are about to leave a space and could loose control over the space if you are the only admin. There is no warning that you will loose access to rooms or control over rooms.

We believe this option (without an additional clear and prominent warning dialog and a red button to confirm) is too dangerous for our users.

Operating system

Linux Fedora 35pre

Browser information

FF92

URL for webapp

https://staging-element.phys.ethz.ch/ (1.8.6-rc.1)

Homeserver

phys.ethz.ch

Have you submitted a rageshake?

No

@rda0 rda0 added the T-Defect label Sep 22, 2021
@germain-gg germain-gg added A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Sep 22, 2021
@rda0
Copy link
Contributor Author

rda0 commented Sep 22, 2021

Related #18592

@nadonomy nadonomy added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 21, 2022
@rda0 rda0 closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Design
Projects
None yet
Development

No branches or pull requests

4 participants