Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CallEventGrouper should use dispatcher to answer/reject calls #18825

Closed
SimonBrandner opened this issue Aug 28, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#6705
Closed

CallEventGrouper should use dispatcher to answer/reject calls #18825

SimonBrandner opened this issue Aug 28, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#6705
Assignees
@SimonBrandner
Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@SimonBrandner
Copy link
Contributor

Not doing this renders matrix-org/matrix-react-sdk#6691 useless when accepting be clicking on a call tile
@SimonBrandner SimonBrandner added A-VoIP S-Critical Prevents work, causes data loss and/or has no workaround T-Defect labels Aug 28, 2021
@SimonBrandner SimonBrandner self-assigned this Aug 28, 2021
@SimonBrandner SimonBrandner mentioned this issue Aug 28, 2021
Merged
@germain-gg germain-gg added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-VoIP and removed S-Critical Prevents work, causes data loss and/or has no workaround A-VoIP labels Aug 31, 2021
@novocaine
Copy link
Contributor

Hi @SimonBrandner - can you please fill in more details explaining the user impact of this defect, and how reproduce it? I'm not sure many people are going to grok this other than you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use disptacher to answer/reject calls in call tiles SimonBrandner/matrix-react-sdk
3 participants
@novocaine @germain-gg @SimonBrandner