Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Editing: Display edits as diffs #123

Closed
manuroe opened this issue Apr 30, 2019 · 2 comments
Closed

Message Editing: Display edits as diffs #123

manuroe opened this issue Apr 30, 2019 · 2 comments
Labels
A-Aggregations A-Message-Editing

Comments

@manuroe
Copy link
Member

manuroe commented Apr 30, 2019 •
edited
Loading

From riot-web created by jryans: element-hq/element-web#9493

We'd like to display edit history as a diff to make it obvious what was added / removed / changed.

However, we should only do this if we can be absolutely certain that we know the immediate predecessor of an edit without gaps, etc.

Screenshot 2019-04-30 at 14 10 57
@manuroe manuroe mentioned this issue Apr 30, 2019
Closed
2 tasks
@manuroe manuroe added phase:4 and removed phase:3 labels Jul 2, 2019
@bmarty
Copy link
Member

bmarty commented Sep 5, 2019

@BillCarsonFr I think we can close this one now?

@bmarty
Copy link
Member

bmarty commented Sep 24, 2019

Who is silent consents :)

@bmarty bmarty closed this as completed Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Aggregations A-Message-Editing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmarty @manuroe