Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Require @electron/asar@^3.2.13 #1767

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: Require @electron/asar@^3.2.13 #1767

merged 1 commit into from
Sep 11, 2024

Conversation

felixrieseberg
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

fix: asar operations that previously failed due to a broken @electron/asar import

@felixrieseberg felixrieseberg requested a review from a team as a code owner September 11, 2024 03:15
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (6de3b9c) to head (7ce317f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
+ Coverage   89.30%   92.50%   +3.19%     
==========================================
  Files          17       17              
  Lines         907      907              
  Branches      187      187              
==========================================
+ Hits          810      839      +29     
  Misses         61       61              
+ Partials       36        7      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixrieseberg felixrieseberg merged commit 0c8cce2 into main Sep 11, 2024
6 checks passed
@felixrieseberg felixrieseberg deleted the felixr-min-asar branch September 11, 2024 03:25
Copy link

🎉 This PR is included in version 18.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants