Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: appDireactory missing for windows-sign options #1731

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

rickymohk
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Fixing windows-sign does not work due to appDirectory missing.

@rickymohk rickymohk requested a review from a team as a code owner June 3, 2024 15:22
Copy link

welcome bot commented Jun 3, 2024

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.06%. Comparing base (00d20b9) to head (7ecc0d8).

Files Patch % Lines
src/win32.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1731   +/-   ##
=======================================
  Coverage   89.06%   89.06%           
=======================================
  Files          17       17           
  Lines         905      905           
  Branches      187      187           
=======================================
  Hits          806      806           
  Misses         62       62           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erickzhao erickzhao requested a review from felixrieseberg June 4, 2024 22:36
Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@felixrieseberg
Copy link
Member

The test failure is unrelated and exists on main, merging.

@felixrieseberg felixrieseberg merged commit 2f92bbd into electron:main Jun 17, 2024
3 of 5 checks passed
Copy link

welcome bot commented Jun 17, 2024

Thanks for your contribution! 🎉

Copy link

🎉 This PR is included in version 18.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants