ESQL: Properly skip datasets with lookup indices #118682
Open
+30
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not rely on specific naming, read the actual settings.
alex-spies
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
idegtiarenko
approved these changes
Dec 13, 2024
craigtaverner
approved these changes
Dec 13, 2024
| } | ||
|
|
||
| public static boolean isLookupDataset(TestsDataset dataset) throws IOException { | ||
| Settings settings = dataset.readSettingsFile(); |
There was a problem hiding this comment.
OK, that was easier than expected!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not rely on specific naming, read the actual settings.
This is required to unblock the backport #118661, which adds a new lookup index dataset whose name doesn't end with
_lookup.When this is merged, I plan to manually forward port it to main; the PR is against 8.x because this is where the problems occur.