-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enable race detector #13827
base: main
Are you sure you want to change the base?
test: enable race detector #13827
Conversation
Unfortunately we can only enable the race detector for ci and unit tests. system-tests are building the apm-server binary (CGO disabled by default) so we can't enable the race detector as it requires cgo.
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
NOTE: |
the make task doesn't disable cgo so be consistent in ci
There's a test that should probably be fixed, seems like a sync problem. |
This uncovered a race condition in elastic-agent-client lib: elastic/elastic-agent-client#125 PR blocked until that's fixed |
Motivation/summary
Unfortunately we can only enable the race detector for ci and unit tests.
system-tests are building the apm-server binary (CGO disabled by default) so we can't enable the race detector as it requires cgo.
Checklist
For functional changes, consider:
How to test these changes
Related issues