Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX 3.0 license expressions not supported #18

Closed
zgtm opened this issue Mar 7, 2018 · 3 comments
Closed

SPDX 3.0 license expressions not supported #18

zgtm opened this issue Mar 7, 2018 · 3 comments

Comments

@zgtm
Copy link

zgtm commented Mar 7, 2018

As discussed in rust-lang/cargo#4930, Cargo documents to use SPDX license expressions as found on https://spdx.org/licenses/. However, listed there are the SPDX 3.0 identifiers that are not compatible to the 2.x identifiers that can be parsed with this crate. Thus, I'd suggest to make the capabilities to parse SPDX 3.0 expressions.

I can do that. However, I'm not totally clear, what would be the best way to achieve that.

I see three possibilities of adding the ability to parse for SPDX 3.0 license identifiers:

  • Adding capabilities to parse SPDX 3.0 expressions to this crate by adding a version tag to the API and
    • using the 2.x identifiers as default (backwards compatible)
    • using the 3.0 identifiers as default (backwards compatible, updating all dependent crates to the new identifiers)
    • using the all possible identifiers as default (backwards compatible)
    • using no default value, forcing all dependent crates to update
  • Creating a new crate that parses SPDX 3.0 expressions.
  • Just replacing the SPDX 2.x identifiers with the SPDX 3.0 identifiers in this crate and consequently dropping support for SPDX 2.x identifiers.

I would suggest the first of these possibilities, with additionally marking the the use of the default value as deprecated.

@zgtm zgtm changed the title Add SPDX 3.0 license expressions SPDX 3.0 license expressions not supported Mar 7, 2018
@wking
Copy link
Contributor

wking commented Mar 7, 2018 via email

@nodakai
Copy link
Contributor

nodakai commented Mar 12, 2018

@wking will do my best...!!

@wking
Copy link
Contributor

wking commented Apr 20, 2018

#11 has landed, so once we cut a release here we can move forward with the Cargo and crates.io updates.

This was referenced Jun 18, 2018
@wking wking closed this as completed in #28 Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants