Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health_check to nginx #128

Open
nixelsolutions opened this issue Apr 26, 2016 · 4 comments
Open

Add health_check to nginx #128

nixelsolutions opened this issue Apr 26, 2016 · 4 comments

Comments

@nixelsolutions
Copy link

Hey @ehazlett many thanks for this wonderful project! I'm wondering if you could add health_check on upstream configuration, as sometimes some containers keep failing with 40x or 50x error codes and those are noted by users as interlock is not dropping those failed containers from the LB pool.

It would be ideal if we could parametrize the URI, attempts, and so on :-)

Thanks a lot!

@ehazlett
Copy link
Owner

You should be able to do it now with the interlock.health_check label. Try that and see if that works.

@chromerobv
Copy link

looking thru code looks like interlock.health_check is only for haproxy.
the only way i think to do this would be to use an nginx image that is built with nginx-upstream_check and then add code the interlock to use the variables and add some code to the template. i've done this for a standalone nginx-proxy if you'd like me add it to interlock.

@ehazlett
Copy link
Owner

Yes we could extend the label to work for nginx. A contribution would be much apprecitated! :)

@chromerobv
Copy link

#179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants