Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong vs. Weak Listener #38

Closed
effad opened this issue Apr 23, 2024 · 3 comments
Closed

Strong vs. Weak Listener #38

effad opened this issue Apr 23, 2024 · 3 comments

Comments

@effad
Copy link
Owner

effad commented Apr 23, 2024

In immediate mode, ValidatorFX currently uses a strong listener to the properties it depends on.
We had a case where this led to a memory leak.

ToDo: Investigate, whether it would be better to use weak listeners.

@effad
Copy link
Owner Author

effad commented Apr 26, 2024

WeakListenerDemo developed which demonstrates the memory leak: By clicking the "Show form" button repeatedly instances of Validator, Check, etc. are accumulated (which can be seen when dumping and analyzing the heap).

@effad
Copy link
Owner Author

effad commented Apr 26, 2024

Fix: Use WeakListener for immediateListener and immediateClearListener.

@effad
Copy link
Owner Author

effad commented May 6, 2024

Since Issue #39 has been fixed, no errors occured an 0.5.1 was released already, thus I close this issue.

@effad effad closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant