-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ray[rllib] does not work in godotrl 0.6.0 #139
Comments
Thanks for letting me know. I think the only solution is to have separate installs:
Then we can specify the rllib deps separately. What do you think? |
Personally I think this is fine. I assume the issue is with the For my use case, not having all would not make too much of a difference, as multiple options can be installed when needed (unless there's a conflict). It will always be possible for one framework to use a dependency not compatible with another framework in the future as well, so For quickly switching between frameworks for training, different virtual environments can still be used. |
@edbeeching @Ivan-267 Okay I agree with you guys. It would have been nice to make every rl backend available in one single environment like it was before, but even if it would work now it could still break with another update. So I guess splitting it up saves us a lot of future headache. Let's go with that solution. :) |
ray[rllib] 2.2.0 does not currently work in godotrl 0.6.0 as it is still expecting an old gym wrapper but we upgraded our godot env to gymnasium. I tried upgrading to ray[rllib] 2.6.0 (which uses gymnasium instead o gym) but here we have a very minor version missmatch which makes the installation fail. More specfifically
sb3
depends ongymnasium==0.28.1
andray
depends ongymnasium==0.26.3
.I would love to host ray package on a separate github fork and loosen the gymnasium version to fix this but the ray project seems to be pretty big and a simple pip install from git does not work.
Any ideas how we can tackle this issue? @edbeeching @Ivan-267
The text was updated successfully, but these errors were encountered: