Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BallChase example: Does best_fruit_distance need a reset after collection? #11

Closed
mischkadb opened this issue Mar 23, 2022 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@mischkadb
Copy link
Contributor

I am not sure if I understand the examples correctly. In the BallChase example best_fruit_distance is initialized and reset in the reset() method. But shouldn't it also be reset after every fruit collection? Only the distance reduction to the first fruit gets rewarded at the moment.

@edbeeching edbeeching added the bug Something isn't working label Mar 24, 2022
@edbeeching
Copy link
Owner

Good spot, this is not working as intended. It dates back to when the task was to collected one fruit and then the environment would reset I then extended the task to multiple fruits. I am planning to push a number of fixes to master today. I will aim to include this as well.

@edbeeching
Copy link
Owner

I've corrected this bug in the latest release. Please let me know if you spot anything else or have other questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants