Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time event trigger point questionable #131

Open
cassava opened this issue Dec 13, 2022 · 1 comment
Open

Time event trigger point questionable #131

cassava opened this issue Dec 13, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@cassava
Copy link
Contributor

cassava commented Dec 13, 2022

If we insert an event with time=20ms, then it will trigger at simulation timepoint 0ms, because sync.time() returns the target time, not the actual time.

See: engine/src/simulation.cpp:987 and engine/src/simulation.cpp:805
@cassava
Copy link
Contributor Author

cassava commented Dec 13, 2022

The correct timing of all this should be thoroughly documented!

@cassava cassava added the help wanted Extra attention is needed label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cassava