-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Che ignores user response when asks whether it should restore workspace or not #1849
Comments
Easy fix. To fix just add boolean parameter to start workspace method of workspace manager. https://github.com/eclipse/che/blob/ce6fb560d3517f94170911425417b8fe91e3293d/wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceService.java#L308-L308 |
@slemeur Please chose the behavior in this case:
|
-1 on this behavior. It is not a suitable Ux. |
@TylerJewell What should we do in this case? |
My -1 is to Stevan's wizard behavior not this issue. |
@slemeur @TylerJewell Can you elaborate on which UX is OK. We prefer having spec on what should be done before we will change API. |
Right now we considering API changes that will allow IDE to either:
Please describe how workspace dialog should work. Then we will be able to implement needed changes. |
The API description you are providing is the good one. @TylerJewell : your feedback is about the UI, not about the ability for the user to choose if he wants to restart the workspace from snapshot, right? |
You should start on the API. My issue is with the IDE ui and dialog box which needs to change. I do not think we will have a Ux design quickly so just do the API change now. |
When there is workspace snapshot and user opens IDE it asks whether workspace should be restored or not. If user press cancel IDE does not send request to restore but default restoring behavior restores WS anyway.
Reproduction Steps:
Expected behavior:
Correct behavior should be either Che doesn't ask user about restoring or send request with flag that forbids restoring enabled by default.
Observed behavior:
Default restoring behavior restores WS
The text was updated successfully, but these errors were encountered: