Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21861] clean.py does not clean up fast_datasharing* files #5308

Open
1 task done
ma30002000 opened this issue Oct 7, 2024 · 2 comments
Open
1 task done

[21861] clean.py does not clean up fast_datasharing* files #5308

ma30002000 opened this issue Oct 7, 2024 · 2 comments
Labels
in progress Issue or PR which is being reviewed

Comments

@ma30002000
Copy link
Contributor

Is there an already existing issue for this?

  • I have searched the existing issues

Expected behavior

clean.py will clean up any orphaned resources in /dev/shm

Current behavior

clean.py does not clean up fast_datasharing* files that are created when data-sharing delivery is active (see DataSharingNotification.hpp)

Steps to reproduce

Setup up two processes with communication adhering to data sharing constraints. Forcibly kill them. Run clean.y.

Fast DDS version/commit

master, 2.14.3, etc.

Platform/Architecture

Ubuntu Focal 20.04 amd64

Transport layer

Shared Memory Transport (SHM), Data-sharing delivery

Additional context

It is unclear to me if the same mechanisms that are used cleaning the other orphaned files can be re-used (delete if file can be locked exclusively).

XML configuration file

No response

Relevant log output

No response

Network traffic capture

No response

@ma30002000 ma30002000 added the triage Issue pending classification label Oct 7, 2024
@JesusPoderoso
Copy link
Contributor

Hi @ma30002000, thanks for your report.
I have successfully reproduced it. We will address it in the following weeks.

@JesusPoderoso JesusPoderoso added bug Issue to report a bug and removed triage Issue pending classification labels Oct 14, 2024
@JesusPoderoso JesusPoderoso changed the title clean.py does not clean up fast_datasharing* files [21861] clean.py does not clean up fast_datasharing* files Oct 14, 2024
@cferreiragonz
Copy link
Contributor

Hello @ma30002000, thanks for your patience.

The behavior you described was the intended design when the tool was initially developed. However, we have internally agreed to include this as a new feature in future releases.

In the meantime, you can achieve the desired behavior by running the following command after killing the processes:
rm -f /dev/shm/fast*

We’ll notify you as soon as the new feature is ready. Thank you for your feedback!

@cferreiragonz cferreiragonz added in progress Issue or PR which is being reviewed and removed bug Issue to report a bug labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Issue or PR which is being reviewed
Projects
None yet
Development

No branches or pull requests

3 participants