feat(p2p): moving gossiped blocks reception from validator to p2p client #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
reviewed
May 7, 2024
p2p/validator.go
Outdated
Comment on lines
85
to
89
| /*err := v.localPubsubServer.PublishWithEvents(context.Background(), gossipedBlock, map[string][]string{EventTypeKey: {EventNewGossipedBlock}}) | ||
| if err != nil { | ||
| v.logger.Error("publishing event", "err", err) | ||
| return false | ||
| } | ||
| }*/ |
There was a problem hiding this comment.
@srene supposed to be commented out?
There was a problem hiding this comment.
yes, but i forgot to remove it. done
srene
force-pushed
the
srene/822-separate-gossip-block-received-from-validation
branch
from
117f052 to
808af10
Compare
danwt
requested changes
May 7, 2024
p2p/gossip.go
Outdated
| @@ -22,6 +22,8 @@ type GossipMessage struct { | |||
| // GossiperOption sets optional parameters of Gossiper. | |||
| type GossiperOption func(*Gossiper) error | |||
|
|
|||
| type NewMessage func(msg *GossipMessage) | |||
There was a problem hiding this comment.
can we rename this GossipMessageHandler
p2p/gossip.go
Outdated
| ps *pubsub.PubSub | ||
| topic *pubsub.Topic | ||
| sub *pubsub.Subscription | ||
| msgReceiver NewMessage |
p2p/gossip.go
Outdated
| } | ||
|
|
||
| // NewGossiper creates new, ready to use instance of Gossiper. | ||
| // | ||
| // Returned Gossiper object can be used for sending (Publishing) and receiving messages in topic identified by topicStr. | ||
| func NewGossiper(host host.Host, ps *pubsub.PubSub, topicStr string, logger types.Logger, options ...GossiperOption) (*Gossiper, error) { | ||
| func NewGossiper(host host.Host, ps *pubsub.PubSub, topicStr string, msgReceiver NewMessage, logger types.Logger, options ...GossiperOption) (*Gossiper, error) { |
Co-authored-by: Daniel T <[email protected]>
mtsitrin
approved these changes
May 8, 2024
mtsitrin
deleted the
srene/822-separate-gossip-block-received-from-validation
branch
omritoptix
pushed a commit
that referenced
this pull request
May 18, 2024
…ent (#811) Co-authored-by: Daniel T <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
This PR decouples p2p gossip blocks validation from blocks reception. By doing that we avoid any interference of block store application in block propagation.
Opening a pull request should be able to meet the following requirements
Close #802
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: