Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing height condition for applying cached blocks from p2p #787

Merged
merged 3 commits into from
May 3, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented May 3, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #786

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner May 3, 2024 12:20
@srene srene self-assigned this May 3, 2024
@omritoptix omritoptix merged commit b97299c into main May 3, 2024
@omritoptix omritoptix deleted the srene/786-fix-blocks-applied-from-p2p-always branch May 3, 2024 16:16
omritoptix pushed a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blocks are not applied when new gossiped block arrived
2 participants