Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(celestia test): fix race in test #755

Merged
merged 3 commits into from
May 1, 2024
Merged

fix(celestia test): fix race in test #755

merged 3 commits into from
May 1, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented May 1, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

Close #754
<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner May 1, 2024 13:03
@danwt danwt requested a review from zale144 May 1, 2024 13:22
zale144
zale144 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@zale144 zale144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@omritoptix omritoptix merged commit 0b36781 into main May 1, 2024
@omritoptix omritoptix deleted the danwt/754-fix-race-in-test branch May 1, 2024 16:32
omritoptix pushed a commit that referenced this pull request May 1, 2024
@danwt @omritoptix
fix(celestia test): fix race in test (#755)
a828e50 
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zale144 zale144 zale144 approved these changes

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix celestia race in test
3 participants
@danwt @omritoptix @zale144