Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(block production): apply block before gossiping #695

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Apr 15, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #654

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner April 15, 2024 16:14
block/produce.go Outdated Show resolved Hide resolved
Co-authored-by: Michael Tsitrin <[email protected]>
@danwt danwt requested a review from mtsitrin April 15, 2024 16:50
@omritoptix
Copy link
Contributor

@danwt just to make sure we have an issue on getting this out of the block production function all together as an error in the gossiping the block shouldn't be related to the block production.

@danwt
Copy link
Contributor Author

danwt commented Apr 16, 2024

@omritoptix yep sure, one thing at a time though!

@omritoptix omritoptix merged commit 5c496b4 into main Apr 16, 2024
4 checks passed
@omritoptix omritoptix deleted the danwt/654-dont-gossip-unapplied-blocks branch April 16, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer nodes could receive blocks that are not applied by the sequencer
4 participants