-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix local da setup #600
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 46.22% 46.23%
=======================================
Files 101 101
Lines 15643 15647 +4
=======================================
+ Hits 7231 7234 +3
+ Misses 7396 7394 -2
- Partials 1016 1019 +3 ☔ View full report in Codecov by Sentry. |
da/da.go
Outdated
Client: Client(pathParts[0]), | ||
} | ||
|
||
if len(pathParts) > 7 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess the if should compare len(pathParts) > 2 instead of > 7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why that? if u access pathParts[6]
u need to validate it exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but if the length of pathParts is 7, that code will never by executed with the current if statement. shouldnt it be len(pathPars)== 7?
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: