Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix local da setup #600

Merged
merged 6 commits into from
Mar 11, 2024
Merged

fix: fix local da setup #600

merged 6 commits into from
Mar 11, 2024

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Mar 6, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested review from omritoptix and srene March 6, 2024 14:39
@mtsitrin mtsitrin linked an issue Mar 6, 2024 that may be closed by this pull request
@mtsitrin mtsitrin marked this pull request as ready for review March 6, 2024 14:39
@mtsitrin mtsitrin requested a review from a team as a code owner March 6, 2024 14:39
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 42.42424% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 46.23%. Comparing base (e206695) to head (8c61b74).

Files Patch % Lines
da/da.go 40.00% 7 Missing and 2 partials ⚠️
da/celestia/celestia.go 0.00% 2 Missing and 1 partial ⚠️
settlement/dymension/dymension.go 57.14% 2 Missing and 1 partial ⚠️
settlement/grpc/grpc.go 0.00% 3 Missing ⚠️
da/grpc/grpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   46.22%   46.23%           
=======================================
  Files         101      101           
  Lines       15643    15647    +4     
=======================================
+ Hits         7231     7234    +3     
+ Misses       7396     7394    -2     
- Partials     1016     1019    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

da/da.go Outdated
Client: Client(pathParts[0]),
}

if len(pathParts) > 7 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess the if should compare len(pathParts) > 2 instead of > 7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why that? if u access pathParts[6] u need to validate it exists

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if the length of pathParts is 7, that code will never by executed with the current if statement. shouldnt it be len(pathPars)== 7?

@mtsitrin mtsitrin requested a review from srene March 10, 2024 07:32
@mtsitrin mtsitrin merged commit 8cd1a10 into main Mar 11, 2024
4 of 5 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/599-fix-local-da-setup branch March 11, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix local DA setup
2 participants