fix: skip trying to apply blocks from DA with mismatched heights.

[omritoptix]

PR Standards

Opening a pull request should be able to meet the following requirements

---

For Author:

• Targeted PR against correct branch
• included the correct type prefix in the PR title
• Linked to Github issue with discussion and accepted design
• Targets only one github issue
• Wrote unit and integration tests
• All CI checks have passed
• Added relevant godoc comments

---

For Reviewer:

• confirmed the correct type prefix in the PR title
• Reviewers assigned
• confirmed all author checklist items have been addressed

---

After reviewer approval:

• In case targets main branch, PR should be squashed and merged.
• In case PR targets a release branch, PR should be rebased.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 46.15%. Comparing base (1c5b853) to head (01e010a).

Files	Patch %	Lines
block/retriever.go	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
- Coverage   46.16%   46.15%   -0.01%     
==========================================
  Files         101      101              
  Lines       15560    15562       +2     
==========================================
  Hits         7183     7183              
- Misses       7368     7369       +1     
- Partials     1009     1010       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mtsitrin]

it's already handled in the applyBlock

if block.Header.Height != m.store.Height()+1 {
		// We crashed after the commit and before updating the store height.
		m.logger.Error("Block not applied. Wrong height", "block height", block.Header.Height, "store height", m.store.Height())
		return nil
	}

[omritoptix]

I know but it's bad handling because it logs an error as the current assumption is that applyBlock expects to get the correct height - as the comment states this error should be logged upon crash recovery.

This was confusing when trying to debug full node not syncing.

if we get this error logged for every block on the DA which is not in the wrong height it's bad.

[mtsitrin]

ok now I understand the pr
BTW, why would a wrong block be committed to the DA?

[omritoptix]

its not a wrong block committed but if for example there is a batch for 100 blocks and you synced until block 20 and failed, next time you'll run your full node, you'll still get the same 100 blocks batch (as you need 20-100) but you'll start applying from block 1 again instead from block 20.