Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed race condition in some DA tests #447

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Aug 14, 2023

  1. fixed bug in da/celestia/mock/server.go
  2. removed the usage of test.NewLogger(t) as it's causes some racing errors (in case go routines exists and writes to log after the test is finished)
  3. changed t.Skip("TODO") to continue in da tests

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner August 14, 2023 17:26
@mtsitrin mtsitrin linked an issue Aug 14, 2023 that may be closed by this pull request
@mtsitrin mtsitrin requested a review from omritoptix August 14, 2023 17:26
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #447 (5bddcaf) into main (1bc4571) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   52.51%   52.51%           
=======================================
  Files          94       94           
  Lines       14423    14423           
=======================================
  Hits         7574     7574           
  Misses       5774     5774           
  Partials     1075     1075           
Files Changed Coverage Δ
da/celestia/mock/server.go 50.32% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtsitrin mtsitrin merged commit c25b4e1 into main Aug 15, 2023
@mtsitrin mtsitrin deleted the mtsitrin/392-flaky-da-test branch August 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky da test
2 participants