Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skipping nil txs in the search result #346

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner June 12, 2023 16:14
@mtsitrin mtsitrin linked an issue Jun 12, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #346 (58208ac) into main (5ffd07d) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   55.68%   55.73%   +0.04%     
==========================================
  Files          81       81              
  Lines       12908    12910       +2     
==========================================
+ Hits         7188     7195       +7     
+ Misses       4743     4739       -4     
+ Partials      977      976       -1     
Impacted Files Coverage Δ
state/txindex/kv/kv.go 66.39% <0.00%> (-0.36%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtsitrin mtsitrin merged commit 3319145 into main Jun 12, 2023
@mtsitrin mtsitrin deleted the mtsitrin/343-panic-in-the-rpc-handler branch June 12, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic in the RPC handler
2 participants