-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: toggle settlement health event upon settlement batch submission status #332
Conversation
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 53.72% 55.06% +1.33%
==========================================
Files 80 80
Lines 12887 12864 -23
==========================================
+ Hits 6924 7084 +160
+ Misses 5025 4817 -208
- Partials 938 963 +25
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…in the settlement level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the excessive usage of panic
instead of returning errors
,
IMO it's bad practice
Overview
This pr moves the batch submission to settlement layer logic from the manager to the settlement.
By that it allows us to encapsulate the logic and handle any possible failures.
The manager will only be notified upon submission success or health status changes.
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: