feat: added max bytes size check when creating the batch #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-batch-size-in-bytes
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 52.22% 52.60% +0.38%
==========================================
Files 70 70
Lines 12566 12627 +61
==========================================
+ Hits 6563 6643 +80
+ Misses 5073 5057 -16
+ Partials 930 927 -3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
omritoptix
requested changes
May 15, 2023
bytes limit can be disable by setting 0 valiue added UT moved mocks to testutil package
|
Fixed and added UT |
omritoptix
reviewed
May 16, 2023
block/manager.go
Outdated
| totalSize = totalSize + block.ToProto().Size() + commit.ToProto().Size() | ||
| if totalSize >= int(m.conf.BlockBatchSizeBytes) { | ||
| totalSize := batch.ToProto().Size() | ||
| if m.conf.BlockBatchSizeBytes > 0 && totalSize >= int(m.conf.BlockBatchSizeBytes) { |
There was a problem hiding this comment.
I suggest adding single validation (vs checking every time) to conf.BlockBatchSizeBytes > 0 as a preliminary stage for starting the rollapp. Look at line 121 for example.
There was a problem hiding this comment.
Actually, It's not the same.
If the flag not provided, it gets the default value by the Viper conf
If it's set explicitly to 0 - I thought it should mean no limit. U say it should enforce the default as in line 121.
Fine, changing it.
omritoptix
reviewed
May 17, 2023
omritoptix
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements:
For Author:
godoccommentsFor Reviewer:
After reviewer approval: