Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad format of rpc subscribe response #278

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

omritoptix
Copy link
Contributor

@omritoptix omritoptix commented Mar 7, 2023

The subscribe response returned to register clients using ws had 2 issues:

  1. It wasn't json-rpc 2.0 compatible
  2. The response body didn't match what clients (such as keplr) were expecting.

@omritoptix omritoptix requested a review from a team as a code owner March 7, 2023 11:24
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #278 (abc5735) into main (6151a3c) will increase coverage by 0.05%.
The diff coverage is 60.86%.

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   52.24%   52.29%   +0.05%     
==========================================
  Files          70       70              
  Lines       12551    12567      +16     
==========================================
+ Hits         6557     6572      +15     
  Misses       5069     5069              
- Partials      925      926       +1     
Impacted Files Coverage Δ
rpc/json/handler.go 82.95% <33.33%> (-1.85%) ⬇️
rpc/json/service.go 64.91% <70.58%> (-0.09%) ⬇️
block/manager.go 67.58% <0.00%> (+1.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@omritoptix omritoptix merged commit 689eabe into main Mar 7, 2023
@omritoptix omritoptix deleted the omritoptix/275-subscribe-expected-response branch March 7, 2023 12:25
@omritoptix omritoptix linked an issue Mar 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subscribe endpoint doesn't return json rpc expected response
2 participants