Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sl client latestHeight not updated upon batch received #256

Closed
omritoptix opened this issue Feb 19, 2023 · 0 comments · Fixed by #257
Closed

sl client latestHeight not updated upon batch received #256

omritoptix opened this issue Feb 19, 2023 · 0 comments · Fixed by #257
Assignees
@omritoptix
Labels
bug Something isn't working

Comments

@omritoptix
Copy link
Contributor

Currently we're only updating the latestHeight upon successful batch submission. Problem is that sometimes the submission returns an error though the batch is still received in the settlement layer.
@omritoptix omritoptix added the bug Something isn't working label Feb 19, 2023
@omritoptix omritoptix self-assigned this Feb 19, 2023
@omritoptix omritoptix linked a pull request Feb 19, 2023 that will close this issue
fix: changed latestHeight to be updated on batch acceptance #257
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omritoptix omritoptix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: changed latestHeight to be updated on batch acceptance dymensionxyz/dymint
1 participant
@omritoptix